feat: update console OAuth2 provider support by HarshMN2345 · Pull Request #3012 · appwrite/console

HarshMN2345 · 2026-04-29T13:34:34Z

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

greptile-apps · 2026-04-29T13:42:44Z

Greptile Summary

This PR consolidates all OAuth2 provider modals into a single dynamic mainOAuth.svelte driven by per-provider parameters fetched from the console API, adds three new providers (FusionAuth, Keycloak, Kick), and fixes scope naming (execution → executions). The buildSecret() function now always emits JSON (fixing the previously flagged raw-string issue), and the scopes picker now handles API failures gracefully without silently clearing selected scopes.

Confidence Score: 3/5

Several previously flagged P1 issues (Yammer missing from switch, null dereference on projectToDelete, paypalSandbox key mismatch) remain open per the thread history — resolve those before merging.

Score reflects three unresolved P1s from prior review threads that are still present in the diff. The new code itself is generally sound, but those open issues cap confidence below 4.

src/routes/(console)/project-[region]-[project]/auth/updateOAuth.ts (Yammer/switch), src/lib/stores/oauth-providers.ts (paypalSandbox key), src/lib/components/organizationUsageLimits.svelte (null dereference)

Important Files Changed

Filename	Overview
src/routes/(console)/project-[region]-[project]/auth/updateOAuth.ts	Full switch-based provider routing; previously flagged issues (Yammer missing, empty-string vs undefined fallbacks) still present per threads
src/routes/(console)/project-[region]-[project]/auth/(providers)/mainOAuth.svelte	Major refactor to dynamic parameters; buildSecret() now always returns JSON (fixing previous raw-string issue); getInitialAppId() duplicates extractAppId() from +page.ts
src/routes/(console)/project-[region]-[project]/auth/settings/+page.ts	New loader fetching per-project and console provider lists; extractAppId() duplicates mainOAuth.svelte's getInitialAppId()
src/routes/(console)/project-[region]-[project]/auth/settings/+page.svelte	Switches to resolvedOAuthProviders; OAuthProvider component safely guarded by {#if selectedProvider && showProvider}; grid layout improvement
src/lib/stores/oauth-providers.ts	All providers consolidated to Main component; new providers (FusionAuth, Keycloak, Kick) added; paypalsandbox renamed to paypalSandbox; Yammer removed — paypalSandbox key mismatch risk flagged in previous thread
src/lib/constants.ts	Scope names corrected (execution → executions); deprecated entries kept for backward compatibility
src/routes/(console)/project-[region]-[project]/overview/api-keys/scopes.svelte	Migrated to dynamic API-based scope list; error handling improved; mounted guard prevents $effect from clearing scopes on API failure
src/lib/components/organizationUsageLimits.svelte	Switched to sdk.forProject for deletion; null dereference on projectToDelete.region still present (previously flagged)

_{Reviews (14): Last reviewed commit: "fix: prevent scope data-loss when listPr..." | Re-trigger Greptile}

- Replace hardcoded OAuth2 provider components with a single dynamic mainOAuth.svelte that fetches labels, placeholders, and hints from listOAuth2Providers; removes 10 now-unused provider-specific files - Load OAuth2 provider list and enabled state from project SDK in +page.ts instead of reading from the project model directly - Fetch API key scopes from listProjectScopes instead of static constants; migrate scopes.svelte to Svelte 5 runes - Add executions.read/write scope definitions and legacy compat pair for execution. -> executions. - Secret field uses write-only card pattern (Tag -> expandable Card); no pre-fill, no silent fallbacks

- authentikDomain → endpoint (Authentik) - auth0Domain → endpoint (Auth0) - tenantID → tenant, clientSecret → applicationSecret (Microsoft) - oktaDomain → domain (Okta) - keyID/teamID → keyId/teamId (Apple) - wellKnownEndpoint/authorizationEndpoint/tokenEndpoint/userinfoEndpoint → wellKnownURL/authorizationURL/tokenUrl/userInfoUrl (OIDC)

- Apple: p8 -> p8File (API field is p8File) - GitLab: clientSecret -> secret (API field is secret) - oauth-providers: paypalsandbox -> paypalSandbox (matches API $id)

Fetch listOAuth2Providers alongside listOAuth2Providers (project) in +page.ts using Promise.all, pass parameters as a prop to mainOAuth. Modal now opens instantly with no spinner or async fetch.

p8File fields now show a drag-and-drop style upload zone by default. Users can click to upload a .p8 file directly or toggle to paste mode for manual entry. Loaded files show a confirmation state with a clear button.

Meldiron · 2026-04-30T13:33:07Z

@greptile

Previously a rejected API call left allScopesList empty and mounted stuck at false with no feedback to the user. Now catches the error, displays an inline alert, and sets mounted in finally so the component settles cleanly.

…nabled Parameters with a non-empty example value are treated as required when the provider is enabled. Params without an example (e.g. GitLab endpoint for self-hosted) remain optional regardless of enabled state.

mounted is now only set to true on successful load. On error, it stays false so the $effect never fires, activeScopes stays empty, and the parent-bound scopes prop is never overwritten with [].

feat: update console OAuth2 provider support

5488f47

greptile-apps Bot reviewed Apr 29, 2026

View reviewed changes

Comment thread src/routes/(console)/project-[region]-[project]/auth/updateOAuth.ts

Comment thread src/routes/(console)/project-[region]-[project]/auth/updateOAuth.ts Outdated

Comment thread src/routes/(console)/project-[region]-[project]/auth/settings/+page.svelte Outdated

HarshMN2345 added 2 commits April 29, 2026 19:22

fix: align console with latest project sdk methods

919109d

format

14154cb

HarshMN2345 requested a review from Meldiron April 29, 2026 14:04

HarshMN2345 added 5 commits April 29, 2026 19:46

fix: remove unsupported yammer oauth provider

75c34eb

remove yammer and change names

8a78402

fix: correct OAuth2 field name mismatches found from API response

838d602

- Apple: p8 -> p8File (API field is p8File) - GitLab: clientSecret -> secret (API field is secret) - oauth-providers: paypalsandbox -> paypalSandbox (matches API $id)

greptile-apps Bot reviewed Apr 29, 2026

View reviewed changes

Comment thread src/lib/components/organizationUsageLimits.svelte

perf: prefetch OAuth2 provider params on page load, remove modal loader

0001eb9

Fetch listOAuth2Providers alongside listOAuth2Providers (project) in +page.ts using Promise.all, pass parameters as a prop to mainOAuth. Modal now opens instantly with no spinner or async fetch.

greptile-apps Bot reviewed Apr 30, 2026

View reviewed changes

Comment thread src/routes/(console)/project-[region]-[project]/auth/updateOAuth.ts Outdated

HarshMN2345 added 4 commits April 30, 2026 14:41

feat: replace Apple p8 textarea with file upload zone

e7810c3

p8File fields now show a drag-and-drop style upload zone by default. Users can click to upload a .p8 file directly or toggle to paste mode for manual entry. Loaded files show a confirmation state with a clear button.

fix-11993-oauth-provider-form-behavior

5686812

fix-11993-oauth-modal-dirty-state

2301a00

fix-11993-restore-oauth-helper-text

16060fb

greptile-apps Bot reviewed Apr 30, 2026

View reviewed changes

Comment thread src/routes/(console)/project-[region]-[project]/auth/(providers)/mainOAuth.svelte

HarshMN2345 added 3 commits April 30, 2026 15:57

fix-11993-clear-non-secret-oauth-fields

5654f12

fix lint

02b1d5e

fix-11993-normalize-oauth-secret-payloads

84ad093

Meldiron approved these changes Apr 30, 2026

View reviewed changes

greptile-apps Bot reviewed Apr 30, 2026

View reviewed changes

Comment thread src/routes/(console)/project-[region]-[project]/overview/api-keys/scopes.svelte

greptile-apps Bot reviewed Apr 30, 2026

View reviewed changes

Comment thread src/routes/(console)/project-[region]-[project]/overview/api-keys/scopes.svelte

HarshMN2345 added 2 commits April 30, 2026 19:35

fix: prevent scope data-loss when listProjectScopes fails

20d09f7

mounted is now only set to true on successful load. On error, it stays false so the $effect never fires, activeScopes stays empty, and the parent-bound scopes prop is never overwritten with [].

HarshMN2345 merged commit 1ea6e32 into main Apr 30, 2026
3 of 4 checks passed

HarshMN2345 deleted the feat-11993-console-oauth2 branch April 30, 2026 14:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update console OAuth2 provider support#3012

feat: update console OAuth2 provider support#3012
HarshMN2345 merged 19 commits intomainfrom
feat-11993-console-oauth2

HarshMN2345 commented Apr 29, 2026

Uh oh!

greptile-apps Bot commented Apr 29, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Meldiron commented Apr 30, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

HarshMN2345 commented Apr 29, 2026

What does this PR do?

Test Plan

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Uh oh!

greptile-apps Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 3/5

Important Files Changed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Meldiron commented Apr 30, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

greptile-apps Bot commented Apr 29, 2026 •

edited

Loading